Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable BC test #322

Merged
merged 2 commits into from
Nov 12, 2023
Merged

Enable BC test #322

merged 2 commits into from
Nov 12, 2023

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Nov 11, 2023

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues -

Copy link

what-the-diff bot commented Nov 11, 2023

PR Summary

  • New Workflow File Added
    The team has added a new file called .github/workflows/bc.yml, replacing the old one with similar name ending with underscore (bc.yml_). This file is crucial for managing automatic tasks whenever code changes are proposed or made.

  • Event Configuration Included
    The new workflow file has been configured to respond to two events: when a new pull request is made or when an existing code is updated (push event). This means the new process will automatically check for issues whenever these events occur.

  • Defined Workflow Name
    For better clarity, a distinctive name has been given to the workflow in .github/workflows/bc.yml. This helps identify this series of tasks among others.

  • Job Configuration has been added
    In the workflow file, a specific job called roave_bc_check has been added with particular settings for Operating System and PHP - a well-known scripting language. This job will automatically execute certain tasks under the specified conditions.

  • Removal of Old Configurations
    Previous configurations tagged under name and jobs in the .github/workflows/bc.yml_ file have been removed as part of this code cleanup effort, following the addition of new and efficient workflow settings.

Copy link

codecov bot commented Nov 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (675d297) 100.00% compared to head (d9c67ff) 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##              master      #322   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       187       187           
===========================================
  Files             13        13           
  Lines            566       566           
===========================================
  Hits             566       566           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tigrov Tigrov marked this pull request as ready for review November 12, 2023 02:19
@vjik vjik merged commit 980fb7a into master Nov 12, 2023
62 of 65 checks passed
@vjik vjik deleted the enable-bc-test branch November 12, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants